Swap to terminal.ReadPassword to remove outdated gopass dependency#1091
Open
lvoytek wants to merge 1 commit intopercona:3.xfrom
Open
Swap to terminal.ReadPassword to remove outdated gopass dependency#1091lvoytek wants to merge 1 commit intopercona:3.xfrom
lvoytek wants to merge 1 commit intopercona:3.xfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The howeyc/gopass dependency has been archived and unmaintained for around 5 years now, and recommends using
golang.org/x/crypto/ssh/terminalas a replacement. This PR replacesgopass.GetPasswd()instances withterminal.ReadPassword(0)to allow the dependency to be removed. This is what is currently done inpt-secure-collect, making this a bit more consistent across tools too.