Print database name when logging pt-kill output to file#405
Open
dreamydb wants to merge 2 commits intopercona:3.xfrom
Open
Print database name when logging pt-kill output to file#405dreamydb wants to merge 2 commits intopercona:3.xfrom
dreamydb wants to merge 2 commits intopercona:3.xfrom
Conversation
Print database name when logging to a file.
Contributor
svetasmirnova
requested changes
Sep 14, 2022
Collaborator
svetasmirnova
left a comment
There was a problem hiding this comment.
Thank you for your contribution.
Your code fails if the default database is not set ($query->{db} is undef), it does not add additional positional formatting for the new element, and breaks tests in the t/pt-kill directory. Please fix these issues.
midla301
approved these changes
Dec 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With multiple dbs in a single instance, its helpful to have pt-kill print the database name to the log file.
This addresses bug: https://blueprints.launchpad.net/percona-toolkit/+spec/pt-kill-log-database
With the suggested code change, an example output would show db name in the fourth column as shown below: