Added option to log queries to database#424
Open
sjalilund wants to merge 2 commits intopercona:3.xfrom
Open
Conversation
Contributor
|
|
svetasmirnova
requested changes
Sep 14, 2022
Collaborator
svetasmirnova
left a comment
svetasmirnova
left a comment
There was a problem hiding this comment.
Thank you for your contribution.
Please add a test case. You will find examples in the directory t.
| query => $query, | ||
| proclist => $pl, | ||
| columns => \@processlist_columns, | ||
| eval_error => $EVAL_ERROR, |
Collaborator
There was a problem hiding this comment.
EVAL_ERROR makes sense only after pt-kill tried to kill the query.
Comment on lines
+7382
to
+7383
| if ( $o->get('logdb') ) { | ||
| if ( $log ) { |
Collaborator
There was a problem hiding this comment.
What if someone specifies option --logdb and not --log?
| newer. Unlike L<"--kill"> which kills the connection for matching queries, | ||
| this option only kills the query, not its connection. | ||
|
|
||
| =item --logdb |
Collaborator
There was a problem hiding this comment.
Not very intuitive name for the option.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added option to log potential victims to the database specified in the dsn that is specified for logging killed queries.
This to get a central place to store the logged potential victims, instead of just locally on the file system of the target database.