Skip to content
This repository was archived by the owner on Jun 1, 2022. It is now read-only.

Pmm 6592 add ports output#225

Open
qwest812 wants to merge 5 commits intomainfrom
PMM-6592-add-ports-output
Open

Pmm 6592 add ports output#225
qwest812 wants to merge 5 commits intomainfrom
PMM-6592-add-ports-output

Conversation

@qwest812
Copy link
Contributor

@qwest812 qwest812 commented May 26, 2022

},
Agents: []listResultAgent{
{AgentType: types.AgentTypeMySQLdExporter, AgentID: "/agent_id/8b732ac3-8256-40b0-a98b-0fd5fa9a1140", ServiceID: "/service_id/4ff49c41-80a1-4030-bc02-cd76e3b0b84a", Status: "RUNNING", MetricsMode: "pull"},
{AgentType: types.AgentTypeMySQLdExporter, AgentID: "/agent_id/8b732ac3-8256-40b0-a98b-0fd5fa9a1140", ServiceID: "/service_id/4ff49c41-80a1-4030-bc02-cd76e3b0b84a", Status: "RUNNING", MetricsMode: "pull", Port: 3306},

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [golangci-lint] reported by reviewdog 🐶
line is 237 characters (lll)


Agent type Status Metrics Mode Agent ID Service ID
mysqld_exporter Running pull /agent_id/8b732ac3-8256-40b0-a98b-0fd5fa9a1140 /service_id/4ff49c41-80a1-4030-bc02-cd76e3b0b84a
Agent type Status Metrics Mode Agent ID Service ID Port

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [golangci-lint] reported by reviewdog 🐶
line is 172 characters (lll)

Agent type Status Metrics Mode Agent ID Service ID
mysqld_exporter Running pull /agent_id/8b732ac3-8256-40b0-a98b-0fd5fa9a1140 /service_id/4ff49c41-80a1-4030-bc02-cd76e3b0b84a
Agent type Status Metrics Mode Agent ID Service ID Port
mysqld_exporter Running pull /agent_id/8b732ac3-8256-40b0-a98b-0fd5fa9a1140 /service_id/4ff49c41-80a1-4030-bc02-cd76e3b0b84a 3306

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [golangci-lint] reported by reviewdog 🐶
line is 172 characters (lll)

},
Agents: []listResultAgent{
{AgentType: types.AgentTypeExternalExporter, AgentID: "/agent_id/8b732ac3-8256-40b0-a98b-0fd5fa9a1149", ServiceID: "/service_id/8ff49c41-80a1-4030-bc02-cd76e3b0b84a", Status: "RUNNING"},
{AgentType: types.AgentTypeExternalExporter, AgentID: "/agent_id/8b732ac3-8256-40b0-a98b-0fd5fa9a1149", ServiceID: "/service_id/8ff49c41-80a1-4030-bc02-cd76e3b0b84a", Status: "RUNNING", Port: 8080},

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [golangci-lint] reported by reviewdog 🐶
line is 218 characters (lll)


Agent type Status Metrics Mode Agent ID Service ID
external-exporter Running /agent_id/8b732ac3-8256-40b0-a98b-0fd5fa9a1149 /service_id/8ff49c41-80a1-4030-bc02-cd76e3b0b84a
Agent type Status Metrics Mode Agent ID Service ID Port

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [golangci-lint] reported by reviewdog 🐶
line is 174 characters (lll)

Agent type Status Metrics Mode Agent ID Service ID
external-exporter Running /agent_id/8b732ac3-8256-40b0-a98b-0fd5fa9a1149 /service_id/8ff49c41-80a1-4030-bc02-cd76e3b0b84a
Agent type Status Metrics Mode Agent ID Service ID Port
external-exporter Running /agent_id/8b732ac3-8256-40b0-a98b-0fd5fa9a1149 /service_id/8ff49c41-80a1-4030-bc02-cd76e3b0b84a 8080

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [golangci-lint] reported by reviewdog 🐶
line is 174 characters (lll)

Agents list.

{{ printf "%-27s" "Agent type" }} {{ printf "%-15s" "Status" }} {{ printf "%-47s" "Agent ID" }} {{ printf "%-47s" "PMM-Agent ID" }} {{ printf "%-47s" "Service ID" }}
{{ printf "%-27s" "Agent type" }} {{ printf "%-15s" "Status" }} {{ printf "%-47s" "Agent ID" }} {{ printf "%-47s" "PMM-Agent ID" }} {{ printf "%-47s" "Service ID" }} {{ printf "%-47s" "Port" }}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [golangci-lint] reported by reviewdog 🐶
line is 193 characters (lll)

AgentID string `json:"agent_id"`
AgentType string `json:"agent_type"`
Status string `json:"status"`
Port int64 `json:"listen_port,omitempty"`

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [golangci-lint] reported by reviewdog 🐶
json(camel): got 'listen_port' want 'listenPort' (tagliatelle)

@qwest812 qwest812 marked this pull request as ready for review May 27, 2022 05:19
@qwest812 qwest812 requested a review from BupycHuk as a code owner May 27, 2022 05:19
Copy link
Contributor

@YaroslavPodorvanov YaroslavPodorvanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@BupycHuk BupycHuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Could you rename title from Pmm 6592 to PMM-6592?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants