Conversation
percona-csalguero
requested review from
BupycHuk and
artemgavrilov
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1135 +/- ##
==========================================
- Coverage 48.98% 48.98% -0.01%
==========================================
Files 182 182
Lines 21323 21334 +11
==========================================
+ Hits 10445 10450 +5
- Misses 9723 9728 +5
- Partials 1155 1156 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
| }) | ||
|
|
||
| if err != nil { | ||
| return errors.Wrap(err, "cannot stop monitoring") |
There was a problem hiding this comment.
Let's for now just log the message and go on.
There was a problem hiding this comment.
Changed to log.Warn
Errors are just logged and won't prevent the methos execution until the end.
JiriCtvrtka
left a comment
JiriCtvrtka
left a comment
There was a problem hiding this comment.
LGTM I left only one minor comment.
services/dbaas/dbaas_client.go
Outdated
| return c.kubernetesClient.StartMonitoring(ctx, in, opts...) | ||
| } | ||
|
|
||
| // StartMonitoring sets up victoria metrics operator to monitor kubernetes cluster. |
There was a problem hiding this comment.
I think comment should start with StopMonitoring.
…ona/pmm-managed into PMM-9965-Remove_vm_operator
6 participants
PMM-9965 DBaaS: Re-registering k8s cluster returns error