This repository was archived by the owner on Jun 21, 2022. It is now read-only.
Open
Conversation
Codecov Report
@@ Coverage Diff @@
## PMM-2.0 #394 +/- ##
==========================================
Coverage ? 49.61%
==========================================
Files ? 98
Lines ? 11656
Branches ? 0
==========================================
Hits ? 5783
Misses ? 5389
Partials ? 484
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
added "with" check for .listen_address in node exporter arg templates
Contributor
|
Hi @Crash129 thank you for your PR, but probably it should be done other way. We already have address of the node on backend side and it can be used from there.. |
|
Has this been implemented? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to: percona/pmm-agent#160