Skip to content
This repository was archived by the owner on Jun 21, 2022. It is now read-only.

PMM-7246 Tweak flags#605

Open
AlekSi wants to merge 4 commits intomainfrom
PMM-7246-tweak-flags
Open

PMM-7246 Tweak flags#605
AlekSi wants to merge 4 commits intomainfrom
PMM-7246-tweak-flags

Conversation

@AlekSi
Copy link
Contributor

@AlekSi AlekSi commented Dec 29, 2020

PMM-7246


  • Tests passed.
  • Feature build pass.
  • (Re)requested review.
  • Fix conflicts with target branch.
  • Update API dependency.
  • Update jira ticket description if needed.
  • Attach screenshots/console output to confirm new behavior to jira ticket, if applicable.


// UpdateParams - reads configuration file and updates corresponding flags.
func (vmp *VictoriaMetricsParams) UpdateParams() error {
// TODO read settings, set -external.url and -external.alert.source

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [golangci-lint] reported by reviewdog 🐶
models/victoriametrics.go:50: Line contains TODO/BUG/FIXME: "TODO read settings, set -external.url an..." (godox)

@codecov
Copy link

codecov bot commented Dec 29, 2020

Codecov Report

Merging #605 (439a6a6) into PMM-2.0 (0db06f7) will increase coverage by 0.07%.
The diff coverage is 55.55%.

Impacted file tree graph

@@             Coverage Diff             @@
##           PMM-2.0     #605      +/-   ##
===========================================
+ Coverage    49.57%   49.65%   +0.07%     
===========================================
  Files          123      123              
  Lines        15577    15562      -15     
===========================================
+ Hits          7722     7727       +5     
+ Misses        7143     7127      -16     
+ Partials       712      708       -4     
Flag Coverage Δ
all 49.06% <55.55%> (+0.07%) ⬆️
cover 49.65% <55.55%> (+0.09%) ⬆️
crosscover 49.65% <55.55%> (+0.07%) ⬆️
update 16.88% <60.00%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
models/settings.go 100.00% <ø> (ø)
models/settings_helpers.go 78.60% <ø> (+3.15%) ⬆️
services/supervisord/supervisord.go 66.66% <ø> (-0.10%) ⬇️
utils/envvars/parser.go 82.53% <0.00%> (+4.92%) ⬆️
models/victoriametrics.go 67.56% <100.00%> (+2.86%) ⬆️
services/supervisord/maintail.go 100.00% <0.00%> (+15.78%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0db06f7...439a6a6. Read the comment docs.

@AlekSi AlekSi marked this pull request as ready for review December 29, 2020 14:03
@AlekSi AlekSi requested a review from BupycHuk as a code owner December 29, 2020 14:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants