Skip to content

PMM-10180: disable http compression by default#954

Closed
ritbl wants to merge 1 commit intomainfrom
PMM-10180-disable-http-compression
Closed

PMM-10180: disable http compression by default#954
ritbl wants to merge 1 commit intomainfrom
PMM-10180-disable-http-compression

Conversation

@ritbl
Copy link
Contributor

@ritbl ritbl commented Jun 21, 2022

github.com/percona/exporter_shared v0.7.3
github.com/percona/go-mysql v0.0.0-20210427141028-73d29c6da78c
github.com/percona/percona-toolkit v3.2.1+incompatible
github.com/percona/promconfig v0.2.4-0.20211110115058-98687f586f54
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Damn! @BupycHuk It seem that we were targeting this percona/promconfig#12 😖

We forgot to merge promconfig or we added this dependency here accidentally?

Comment on lines +199 to +201
for _, scfg := range scfgs {
scfg.DisableCompression = true
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But how can I enable it then?

@BupycHuk BupycHuk closed this Jun 7, 2023
@BupycHuk BupycHuk deleted the PMM-10180-disable-http-compression branch June 7, 2023 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants