pcp-system-tools: restore backward compatibility with older pmapi versions#2509
Closed
orasagar wants to merge 1 commit intoperformancecopilot:mainfrom
Closed
pcp-system-tools: restore backward compatibility with older pmapi versions#2509orasagar wants to merge 1 commit intoperformancecopilot:mainfrom
orasagar wants to merge 1 commit intoperformancecopilot:mainfrom
Conversation
Commit 0a37ed0 introduced support for pmapi version 4, but upgrading to the latest pmapi is not currently desired. This change updates pcp-iostat, mpstat, pidstat, and ps to fall back to tv_usec when tv_nsec is unavailable during timestamp delta calculation, ensuring compatibility with older pmapi versions and collectors that only expose tv_usec.
orasagar
changed the title
Member
|
I'm going to "speak" with @orasagar via email to understand the use case here ... a priori I don't think this is the sort of thing we want to carry forward in the PCP code base. |
Member
|
Agreed, I don't think this category of changes should be merged upstream. |
Contributor
Author
|
@natoscott after having discussion with @kmcdonell i do also agree that it should not be upstream, closing this out |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit 0a37ed0 introduced support for pmapi version 4, but upgrading to the latest pmapi is not currently desired. This change updates pcp-iostat, mpstat, pidstat, and ps to fall back to tv_usec when tv_nsec is unavailable during timestamp delta calculation, ensuring compatibility with older pmapi versions and collectors that only expose tv_usec.