nix: extract K8s manifests, remove BCC, improve build isolation#2516
Open
randomizedcoder wants to merge 1 commit intoperformancecopilot:mainfrom
Open
nix: extract K8s manifests, remove BCC, improve build isolation#2516randomizedcoder wants to merge 1 commit intoperformancecopilot:mainfrom
randomizedcoder wants to merge 1 commit intoperformancecopilot:mainfrom
Conversation
Standalone K8s manifest generation (nix build .#pcp-k8s-manifests)
so users can inspect or deploy PCP's DaemonSet without minikube.
Manifests are validated at build time with kube-linter; all 9
default findings are suppressed with documented rationale (PCP is
a privileged node monitoring agent that needs host PID, /proc,
/sys, and BPF access by design).
The nix/k8s-test module now imports from nix/k8s-manifests with a
namespace override ("pcp-test") for test isolation, replacing the
old nix/k8s-test/manifests.nix.
Completely remove BCC (pmdabcc was removed from PCP upstream in
commit 9a576b8). This drops the unused bcc build dependency
from nix/package.nix, invalid --with-pmdabcc configure flags,
the dead nix/bcc.nix NixOS module (304 lines), and all enableBcc
plumbing from nix/microvm.nix and flake.nix.
Pin minikube's --kubernetes-version to v1.33.0 so the test suite
doesn't break when nixpkgs updates minikube. The start script
now auto-deletes stale clusters with incompatible k8s versions
instead of failing.
Exclude nix/, flake.nix, flake.lock, and CLAUDE.md from the PCP
source filter so that Nix infrastructure changes don't trigger a
full PCP rebuild.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Author
|
Generates the manifests. Also runs the manifest lint |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Standalone K8s manifest generation (nix build .#pcp-k8s-manifests) so users can inspect or deploy PCP's DaemonSet without minikube. Manifests are validated at build time with kube-linter; all 9 default findings are suppressed with documented rationale (PCP is a privileged node monitoring agent that needs host PID, /proc, /sys, and BPF access by design).
The nix/k8s-test module now imports from nix/k8s-manifests with a namespace override ("pcp-test") for test isolation, replacing the old nix/k8s-test/manifests.nix.
Completely remove BCC (pmdabcc was removed from PCP upstream in commit 9a576b8). This drops the unused bcc build dependency from nix/package.nix, invalid --with-pmdabcc configure flags, the dead nix/bcc.nix NixOS module (304 lines), and all enableBcc plumbing from nix/microvm.nix and flake.nix.
Pin minikube's --kubernetes-version to v1.33.0 so the test suite doesn't break when nixpkgs updates minikube. The start script now auto-deletes stale clusters with incompatible k8s versions instead of failing.
Exclude nix/, flake.nix, flake.lock, and CLAUDE.md from the PCP source filter so that Nix infrastructure changes don't trigger a full PCP rebuild.