Fix/report save location#13
Merged
marksie1988 merged 4 commits intoperiphery-security:mainfrom Mar 9, 2026
Merged
Conversation
added 4 commits
March 6, 2026 13:12
- cve_scan/scanner.py: remove unreachable duplicate code block after return in _scan_service (dead code from a bad copy-paste refactor) - cve_scan/scanner.py: fix NVD rate-limit detection using wrong HTTP status code; NVD returns 429 (Too Many Requests) for rate limits, not 403 (Forbidden). Retrying on 403 was pointless and indicated an auth problem. - password_scan/scanner.py: fix UnboundLocalError when credentials list is empty; variable i was unbound if the for-loop never executed, causing tested_count=i+1 to crash. Initialize i=-1 before the loop. - password_scan/scanner.py: fix backward-compat scan_host() calling scanner.scan_host(host, ports) without the required mac argument, passing ports into the mac parameter and leaving ports missing.
Threads unprivileged=True from CLI through to nmap, bypassing the privilege check and passing --unprivileged to all nmap invocations (ping sweep, port scan, service probe) so users on macOS can run without sudo using TCP connect scans. Also threads verbose=True from CLI through to the scanner so --verbose prints phase-by-phase nmap progress, discovered hosts, and open ports as they are found.
Adds a colorblind.yaml skin using the Okabe-Ito (2008) palette — the scientific standard for colorblind accessibility, safe for deuteranopia, protanopia, and tritanopia. Sky blue replaces cyan, orange replaces yellow warnings, vermillion replaces red for danger, and all icons fall back to ASCII text forms ([OK], [X], [!]) so meaning is never conveyed by color alone. --colorblind hot-swaps the theme before the scan runs so all output including results, risk grades, and CVE badges renders in the safe palette.
output_dir was defaulting to get_config_dir()/scans which buried scan results inside ~/Library/Application Support/edgewalker/scans on macOS — a hidden system directory users can't easily find. Now uses a dedicated get_data_dir() (defaulting to ~/.edgewalker) so results land in ~/.edgewalker/scans, visible and accessible from the terminal. Override with EW_DATA_DIR env var.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information