Merged
Conversation
output_dir was defaulting to get_config_dir()/scans which buried scan results inside ~/Library/Application Support/edgewalker/scans on macOS — a hidden system directory users can't easily find. Now uses a dedicated get_data_dir() (defaulting to ~/.edgewalker) so results land in ~/.edgewalker/scans, visible and accessible from the terminal. Override with EW_DATA_DIR env var.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Currently scans are in the
.configfolder which could be difficult to find one some OS'sWhat is the new behavior?
Scan results are saved in
{home}/.edgewalkerfor better user experienceDoes this PR introduce a breaking change?
Other information