Conversation
gemanor
left a comment
gemanor
left a comment
There was a problem hiding this comment.
Great progress. Let's continue the discussion on the comments
source/cli.deno.tsx
Outdated
| @@ -0,0 +1,14 @@ | |||
| #!/usr/bin/env -S deno run | |||
package.json
Outdated
| "type": "module", | ||
| "engines": { | ||
| "node": ">=22" | ||
| "node": ">=20" |
There was a problem hiding this comment.
We intentionally used node 22 to avoid errors that related to Pastel
package.json
Outdated
| "simple-check": "npx tsx ./source/cli.tsx pdp check -u filip@permit.io -a create -r task", | ||
| "test:ts": "tsc --noEmit" | ||
| "test:ts": "tsc --noEmit", | ||
| "start": "node dist/cli.js" |
There was a problem hiding this comment.
Why do we need it? As an alias for the CLI?
README.md
Outdated
| ### Using Deno | ||
|
|
||
| ```bash | ||
| deno install --allow-read --allow-write --allow-net --allow-env --allow-run --allow-sys https://raw.githubusercontent.com/permitio/permit-cli/main/source/cli.deno.tsx | ||
| ``` | ||
|
|
There was a problem hiding this comment.
Maybe I explained myself wrong, but our mission here is to create a binary that does not require either Deno or Node to be installed. We used Deno because it support the generation of such binaries using the deno compile command
|
|
||
| ```bash | ||
| # Run the PDP container | ||
| $ permit pdp run |
There was a problem hiding this comment.
AFAIK CLI commands are usually documented with the $ sign; any special reason you removed it?
.github/workflows/ci.yml
Outdated
| path: dist/ | ||
| retention-days: 7 | ||
|
|
||
| - name: Upload Deno artifact |
There was a problem hiding this comment.
After creating the binaries (using deno compile, see in further comment), we should find a testing as a service platform that allows us to run it on three OSs (Windows, OS X, Linux) and check the executable is working.
maya-barak
force-pushed
the
maya/per-12080-new-deno-and-npm
branch
from
4d1feae to
5b47448
Compare
maya-barak
force-pushed
the
maya/per-12080-new-deno-and-npm
branch
from
6e2003f to
9964b9e
Compare
2 participants
Pull Request
Description
Type of Change
Checklist
mainwith an appropriate name (e.g.,fix/issue-123,feature/new-command)New Command Details (if applicable)
src/commandsdirectoryAuthProvidercomponentapiKeyargumentAdditional Notes
Screenshots/Recordings