fix: resolve lint errors from eslint-plugin-llm-core 0.8.0#26
Conversation
- Extract magic Unicode code points to named constants (no-magic-numbers) - Add explicit type annotation on exported function default param (explicit-export-types) - Set ignoreParameters on no-inferrable-types to resolve rule conflict - Extract complexity threshold to named constant Ref: pertrai1/eslint-plugin-llm-core#71
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThis PR refines ESLint configuration by introducing a Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Possibly related issues
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
View your CI Pipeline Execution ↗ for commit 54e1ff3
☁️ Nx Cloud last updated this comment at |
Summary
Fixes lint errors surfaced by upgrading
eslint-plugin-llm-corefrom 0.6.0 to 0.8.0.Changes
scanner.ts— Extract 11 magic Unicode code points to named constants (llm-core/no-magic-numbers)parser.ts— Add explicit: numbertype annotation onlineNumberdefault param (llm-core/explicit-export-types)eslint.config.mjs— SetignoreParameters: trueon@typescript-eslint/no-inferrable-typesto resolve conflict withllm-core/explicit-export-types; extract complexity threshold to named constantRule conflict
llm-core/explicit-export-typesrequires type annotations on exported function params, but@typescript-eslint/no-inferrable-types(from@nx/eslint-pluginflat/typescript) forbids annotations when the type is trivially inferred from a default value. Reported upstream: pertrai1/eslint-plugin-llm-core#71Verification
npx nx affected -t build,test,lintpasses (0 errors, 264 tests green)Summary by CodeRabbit
Refactor
Chores