Add support for: WithMaxDepth, WithAppendSlice, WithKeyStringer#5
Open
shivamMg wants to merge 1 commit intopeterbourgon:masterfrom
Open
Add support for: WithMaxDepth, WithAppendSlice, WithKeyStringer#5shivamMg wants to merge 1 commit intopeterbourgon:masterfrom
shivamMg wants to merge 1 commit intopeterbourgon:masterfrom
Conversation
Owner
|
Can you say a bit more why you want these changes? AppendSlice makes sense, but why the others? |
Author
|
I was trying to use the library with maps returned from YAML unmarshal. Most use cases arose from there.
I do understand that these might not be super-relevant for the library. Feel free to ignore the PR. |
Owner
|
Yeah, I'll probably add the MaxDepth option, and might add the AppendSlice option, but I think the KeyStringer bit is out of scope. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.