Make single-server fast path tests actually use a single server#1127
Merged
petergoldstein merged 1 commit intoJul 12, 2026
Merged
Conversation
The tests for the single server fast path batch methods used test helpers that build clients with two address aliases for the same memcached process (https://github.com/petergoldstein/dalli/blob/main/test/utils/memcached_manager.rb#L43-L47), so every client got a 2 server ring and batch operations were always going through the pipelined path. Add a `single_server_client` test helper that builds a client with a single address, and use it in those tests so they actually hit the fast path.
Owner
|
Thanks @ilianah |
petergoldstein
added a commit
to ilianah/dalli
that referenced
this pull request
Jul 13, 2026
Adds a Features entry for delete_multi returning a deleted-key count (petergoldstein#1126) and a Maintenance entry for the single-server fast path test fix (petergoldstein#1127), bringing the Unreleased section current with all substantive PRs merged since 5.0.5. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tests for the single server fast path batch methods used test helpers that build clients with two address aliases for the same memcached process (https://github.com/petergoldstein/dalli/blob/main/test/utils/memcached_manager.rb#L43-L47), so every client got a 2 server ring and batch operations were always going through the pipelined path.
Add a
single_server_clienttest helper that builds a client with a single address, and use it in those tests so they actually hit the fast path.