feat: verify S209 @kamael0909 bounty — NO verdict, failures set is main-thread-only (#530)

[xliry]

Issue: #204
Submission: #204 (comment)
Author: @kamael0909

Problem (in our own words)

The submission claims that the failures set in the parallel batch runner is mutated from worker threads without lock protection, constituting a thread-safety violation. It identifies two call sites (_queue_parallel_tasks and _complete_parallel_future) where failures.add(idx) is called outside a lock.

Evidence

• _runner_parallel_execution.py: _run_parallel_task (the worker function) does NOT receive failures — only progress_failures and started_at
• _runner_parallel_execution.py: _queue_parallel_tasks runs in main thread (sequential loop submitting to executor)
• _runner_parallel_execution.py: _complete_parallel_future runs in main thread (called from _drain_parallel_completions via as_completed)
• runner_parallel.py:56-85: execute_batches calls _queue_parallel_tasks then _drain_parallel_completions sequentially in main thread

Fix

No fix needed — verdict is NO

Verdict

Question	Answer	Reasoning
Is this poor engineering?	NO	The failures set is only accessed from the main thread; no thread-safety issue exists
Is this at least somewhat significant?	NO	The claimed bug does not exist — the threading model was misidentified

Final verdict: NO

Scores

Criterion	Score
Significance	0/10
Originality	3/10
Core Impact	0/10
Overall	1/10

Summary

The submission incorrectly claims a thread-safety violation in the parallel batch runner. The failures set is only ever accessed from the main thread — worker threads run _run_parallel_task, which does not receive failures as a parameter. The progress_failures set IS accessed from workers and IS properly lock-protected, which is the correct differentiation, not an inconsistency. S024 by @jasonsutter87 makes the same incorrect claim.

Why Desloppify Missed This

• What should catch: N/A — the claimed issue does not exist
• Why not caught: There is nothing to catch; the code is correctly designed
• What could catch: A thread-access analyzer could confirm that failures is main-thread-only

Verdict Files

• Verdict JSON
• Verdict Report

Generated with Lota