feat: verify S224 @g5n-dev bounty — NO verdict, duplicate of S153 (#536)#347
Open
xliry wants to merge 4 commits intopeteromallet:mainfrom
Open
feat: verify S224 @g5n-dev bounty — NO verdict, duplicate of S153 (#536)#347xliry wants to merge 4 commits intopeteromallet:mainfrom
xliry wants to merge 4 commits intopeteromallet:mainfrom
Conversation
… (#451) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…eld confirmed (#456) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
S224 reports XXE vulnerability in deps_support.py:10-13 (defusedxml fallback to stdlib). This is a duplicate of S153 (@codenan42), which was submitted 18+ hours earlier and already verified YES_WITH_CAVEATS. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #204
Submission: #204 (comment)
Author: @g5n-dev
Problem (in our own words)
S224 reports an XXE (XML External Entity) vulnerability in
desloppify/languages/csharp/detectors/deps_support.py:10-13, wheredefusedxmlfalls back to the stdlibxml.etree.ElementTreeparser when the optional dependency is not installed. The submission claims CVSS 7.5 and file exfiltration via malicious.csprojfiles.Evidence
deps_support.py:10-13— fallback import fromdefusedxmltoxml.etree.ElementTree(confirmed at commit 6eb2065)deps_support.py:91—ET.parse(csproj_file).getroot()parses attacker-controlled.csprojfilespyproject.toml—dependencies = [](empty),defusedxmlonly in[full]extras at snapshotxml.etree.ElementTreerejects external entities (ParseError: undefined entity), so the specific XXE/file-exfiltration claim is incorrect — but entity expansion (billion laughs) is validFix
No fix needed — verdict is NO (duplicate of S153).
Verdict
Final verdict: NO — duplicate of S153
Scores
Summary
S224 is a duplicate of S153 (@codenan42), which was submitted over 18 hours earlier and already verified YES_WITH_CAVEATS. Both submissions identify the identical issue: the
defusedxml→ stdlib fallback indeps_support.py:10-13. The XXE file-exfiltration claim is technically incorrect (Python's expat parser rejects external entities), though entity expansion attacks are valid. No credit for duplicates.Why Desloppify Missed This
xml.etree.ElementTreeusage withoutdefusedxml, or flagging optional security dependenciesVerdict Files
Generated with Lota