Skip to content

feat: verify S224 @g5n-dev bounty — NO verdict, duplicate of S153 (#536)#347

Open
xliry wants to merge 4 commits intopeteromallet:mainfrom
xliry:task-536-lota-1
Open

feat: verify S224 @g5n-dev bounty — NO verdict, duplicate of S153 (#536)#347
xliry wants to merge 4 commits intopeteromallet:mainfrom
xliry:task-536-lota-1

Conversation

@xliry
Copy link

@xliry xliry commented Mar 7, 2026

Issue: #204
Submission: #204 (comment)
Author: @g5n-dev

Problem (in our own words)

S224 reports an XXE (XML External Entity) vulnerability in desloppify/languages/csharp/detectors/deps_support.py:10-13, where defusedxml falls back to the stdlib xml.etree.ElementTree parser when the optional dependency is not installed. The submission claims CVSS 7.5 and file exfiltration via malicious .csproj files.

Evidence

  • deps_support.py:10-13 — fallback import from defusedxml to xml.etree.ElementTree (confirmed at commit 6eb2065)
  • deps_support.py:91ET.parse(csproj_file).getroot() parses attacker-controlled .csproj files
  • pyproject.tomldependencies = [] (empty), defusedxml only in [full] extras at snapshot
  • S153 by @codenan42 (2026-03-05T14:02:14Z) — identical issue, submitted 18+ hours earlier, already verified YES_WITH_CAVEATS
  • Python's stdlib xml.etree.ElementTree rejects external entities (ParseError: undefined entity), so the specific XXE/file-exfiltration claim is incorrect — but entity expansion (billion laughs) is valid

Fix

No fix needed — verdict is NO (duplicate of S153).

Verdict

Question Answer Reasoning
Is this poor engineering? YES Falling back to an unsafe XML parser silently is a security antipattern
Is this at least somewhat significant? YES Entity expansion attacks work; but this was already reported as S153

Final verdict: NO — duplicate of S153

Scores

Criterion Score
Significance 0/10
Originality 0/10
Core Impact 0/10
Overall 0/10

Summary

S224 is a duplicate of S153 (@codenan42), which was submitted over 18 hours earlier and already verified YES_WITH_CAVEATS. Both submissions identify the identical issue: the defusedxml → stdlib fallback in deps_support.py:10-13. The XXE file-exfiltration claim is technically incorrect (Python's expat parser rejects external entities), though entity expansion attacks are valid. No credit for duplicates.

Why Desloppify Missed This

  • What should catch: A security-focused detector scanning for unsafe XML parsing patterns
  • Why not caught: Desloppify does not have XML security pattern detection; the code was intentionally written with a fallback
  • What could catch: A detector flagging xml.etree.ElementTree usage without defusedxml, or flagging optional security dependencies

Verdict Files

Generated with Lota

xliry and others added 4 commits March 7, 2026 03:58
… (#451)

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…eld confirmed (#456)

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
S224 reports XXE vulnerability in deps_support.py:10-13 (defusedxml
fallback to stdlib). This is a duplicate of S153 (@codenan42), which
was submitted 18+ hours earlier and already verified YES_WITH_CAVEATS.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant