feat: verify S244 @sungdark bounty — NO verdict, duplicate of S028#360
Open
xliry wants to merge 4 commits intopeteromallet:mainfrom
Open
feat: verify S244 @sungdark bounty — NO verdict, duplicate of S028#360xliry wants to merge 4 commits intopeteromallet:mainfrom
xliry wants to merge 4 commits intopeteromallet:mainfrom
Conversation
… (#451) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…eld confirmed (#456) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…548) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #204
Submission: #204 (comment)
Author: @sungdark
Problem (in our own words)
S244 claims that global mutable singleton state in
registry.py(_RUNTIME),config.py, and runtime state modules makes parallel execution impossible and breaks test isolation.Evidence
base/registry.py:397:_RUNTIME = _RegistryRuntime(...)is a module-level mutable singleton — confirmed.base/registry.py:418-428:register_detector()mutates_RUNTIMEdirectly — confirmed.base/config.py: No global mutable state exists.load_config(path)andsave_config(config, path)are stateless functions with explicit parameters — claim refuted.base/registry.py:434-441:reset_registered_detectors()exists for test isolation, mitigating the concern.Fix
No fix needed — verdict is NO.
Verdict
_RUNTIMEglobal mutable singleton in registry.py is a real pattern concernFinal verdict: NO
Scores
Summary
The
_RUNTIMEglobal mutable singleton observation inregistry.pyis factually correct but duplicates S028 (@dayi1000), which was already credited for identifying the concrete stale-binding bug caused by this same global state. S181 made the identical "global state anti-pattern in registry" observation and was rejected as a duplicate. Theconfig.pyclaim is factually incorrect — it has no global mutable state.Why Desloppify Missed This
global_mutable_configdetectorVerdict Files
Generated with Lota