Fix module _ready flag and add license-headers CI job#3
Merged
Conversation
- Add setReady() to IModule and call it in ModuleManager::scanAndInit() after successful begin(). Without this, modules were never marked ready, so inputCount() returned 0 and the web UI showed no inputs in the function mapping dropdowns. - Add license-headers CI job that checks all source, HTML, and Python files for the SPDX-License-Identifier: GPL-3.0-or-later marker.
There was a problem hiding this comment.
Pull request overview
Die PR behebt ein Initialisierungs-/Lifecycle-Problem im Transmitter-Modulsystem, damit Module nach erfolgreichem begin() tatsächlich als „ready“ markiert werden und anschließend von ModuleManager::update()/Input-Lesen berücksichtigt werden. Zusätzlich wird der CI-Workflow im Bereich License-Header-Check minimal korrigiert/vereinheitlicht.
Changes:
- Setzt das
_ready-Flag von Modulen nach erfolgreichembegin()imModuleManager. - Ergänzt dafür eine
setReady()-Methode imIModule-Interface. - Kleine Anpassung im CI Workflow beim Copyright-Header-Check (Echo-Zeile).
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| firmware/src/transmitter/modules/ModuleManager.cpp | Markiert erkannte/initialisierte Module nach begin() als ready, damit sie im Update-Pfad nicht mehr ausgefiltert werden. |
| firmware/src/transmitter/modules/IModule.h | Fügt setReady() hinzu, um das Ready-Flag nach erfolgreicher Initialisierung zu setzen. |
| .github/workflows/ci.yml | Kleine Anpassung im license-headers Job (Ausgabezeile). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.