Added new menu OST

[zabidenhtf]

No description provided.

[zabidenhtf]

Hello, when my pr will be merged?

[petitlapin]

Hi, I won't have time to test it before 10 days unfortunately.
Multiple points:

• Are you the creator of the music? If yes, do you confirm the license is GPLv3+?
• If not, where did you find it and did you check the license is coherent with ours?
• Would it make sense to have an option in the menu to choose between the old and new audio? This way the users can choose which one they prefer.

[zabidenhtf]

Yes, I'm author, if you want I'm can send on email source LMMS file project

[zabidenhtf]

And also I'm confirmed license

[zabidenhtf]

Also, im now making update with new ROYALTY FREE sounds, im will make PR later (Because in my opinion old 2000s sounds is BAD)

[zabidenhtf]

Hello, what about this PR?

[petitlapin]

I finally found the time to test!
The sound is nice, I have a few notes:

• I think it would be better if we manage to create an "infinite" loop on the audio without the blank at the end (like the end of the audio should match with the beginning), do you think it is doable?
• The file in wav format in 10MB which is quite big, is it possible to encode it in a smaller format usable by sdl_mixer without quality loss?
• I would really like to have an option to use the previous sounds or the new ones. I'm fine with the new ones being the default ones too so by default, it will be your sounds :).

[zabidenhtf]

1. Ok, sure im can make loop
2. Ok, im can compress it to ogg or mp3
3. Ok, im make switch to select new or old

[zabidenhtf]

Im converted it into OGG, and now it not 10 MB

[zabidenhtf]

And also, what about adding source LMMS source file into project? Because in Ri-li was XM files (Fast tracker II source files).

[petitlapin]

And also, what about adding source LMMS source file into project? Because in Ri-li was XM files (Fast tracker II source files).

yes please, having the source file (and in the readme a quick "how to generate the audio" is good)

[petitlapin]

Im converted it into OGG, and now it not 10 MB

Thank you!

[zabidenhtf]

Added LMMS source

[zabidenhtf]

And also, im will add more my copyrights (like in readme, authors)

[zabidenhtf]

Also, in my opinion for Li-Ri doesn't need 2000s stuff

[petitlapin]

Also, in my opinion for Li-Ri doesn't need 2000s stuff

It's not because it does not fit your taste that other people don't enjoy these sounds and might even prefer them to the ones you have/will create. So the best compromise is to allow the users to choose which sounds they prefer.

And it's not because it has been created 20 years ago that it is "bad". It's a different generation, with different design/trends :).

[zabidenhtf]

And also, i dont know how make UI switch

[zabidenhtf]

Can you give for me idea (because in code you can switch and in ui no)

[petitlapin]

Can you give for me idea (because in code you can switch and in ui no)

In Menu::InitMain_Options we need to add a new button, and in the loop handling the menu, we need to store in preferences depending on the value. I would suggest to not add any image, just texts: "theme:" with values: "Zabiden"/"Maf"

I can take a look to add it myself if you want.

[zabidenhtf]

ALSO, IM FORGOT TO RETURN COPYRIGHT FOR MENU_LEGACY.mod

[zabidenhtf]

Returned copyright

[zabidenhtf]

Can you give for me idea (because in code you can switch and in ui no)

In Menu::InitMain_Options we need to add a new button, and in the loop handling the menu, we need to store in preferences depending on the value. I would suggest to not add any image, just texts: "theme:" with values: "Zabiden"/"Maf"

I can take a look to add it myself if you want.

Ok, im give for you this task make selector

[zabidenhtf]

Hello, what about your update?

[petitlapin]

Hello, what about your update?

I have an almost working patch. Is it ok with you if I directly push in your branch (I'll do a commit on top for now, then I would like to be able to rewrite the history directly, it will be easier to clean it)?

[zabidenhtf]

Hello, look, im made new melody for Li-ri (You can write issues with this song, im will fix)

[zabidenhtf]

Also, im added another new melody (By me)

[petitlapin]

Do you plan to make more changes on this PR or is it ready for you?

If it is ready, as you can see there are a lot of conflicts due to the changes we directly did in master. If you want to take care of them, I can let you, else I can handle them before next week (I'm used to dealing with these kind of conflicts).

[zabidenhtf]

I'm ready to upload this update

[petitlapin]

I generated the audio with LMMS but I have a blank at the end of each ingame file, can you please confirm if the pushed lmms files are the latest ones?
Once it is fixed, I guess it's good to be merged for me, so please double check I didn't break anything (I did some changes) and once there is the correct lmms files, I'll generate again the audio and I'll merge :).

[zabidenhtf]

Yes, sure this is latest versions of my music

[zabidenhtf]

Sorry for no respond

[zabidenhtf]

And you can merge this changes

[petitlapin]

Sorry for no respond

No worry at all! As I already said, we all have lives and different priorities. I just merged it, thank you a lot for this improvement!