fix: forward LISTEN/NOTIFY/UNLISTEN to backend in session mode#800
Merged
levkk merged 4 commits intopgdogdev:mainfrom Mar 2, 2026
Merged
fix: forward LISTEN/NOTIFY/UNLISTEN to backend in session mode#800levkk merged 4 commits intopgdogdev:mainfrom
levkk merged 4 commits intopgdogdev:mainfrom
Conversation
In session mode, forward LISTEN/NOTIFY/UNLISTEN directly to the backend as regular queries instead of going through the internal pub/sub system. This fixes "pub/sub disabled" errors when pub_sub_channel_size = 0 and replicas are configured.
|
|
Contributor
Author
|
If this is the right direction I'll get some test coverage over it too. |
Collaborator
|
Yes, this is correct! |
Contributor
Author
Nice. I'll figure out how to get some test coverage. |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Integration test verifying LISTEN/NOTIFY works in session mode. Regression test verifying LISTEN is not rejected with "pub/sub disabled" when pub_sub_channel_size = 0 in session mode.
Contributor
Author
|
@levkk not sure if you think the regression integration test is worth the lines, but let me know :) |
Collaborator
|
I'll never say no to tests ;) |
Full notification delivery in session mode needs further work. This test verifies the original bug: LISTEN is no longer rejected with "pub/sub disabled" in session mode.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In session mode, forward LISTEN/NOTIFY/UNLISTEN directly to the backend as regular queries instead of going through the internal pub/sub system. Fixes "pub/sub disabled" errors when pub_sub_channel_size = 0 and replicas are configured.