Conversation
|
LGTM |
| } | ||
|
|
||
| /* | ||
| * Helper Method from JNIHelp.c from android source code |
There was a problem hiding this comment.
Could you modify the comment for functions following the format below?
/*
* function name: description about its functionality
*/
| /* | ||
| * Helper Method from JNIHelp.c from android source code | ||
| */ | ||
| static jmethodID FindMethod(JNIEnv* env, |
There was a problem hiding this comment.
Could you naming the function following the naming rule? For example, jq_find_method
| const char* className, | ||
| const char* methodName, | ||
| const char* descriptor) { | ||
| // This method is only valid for classes in the core library which are |
| { | ||
| ereport(ERROR, (errmsg("java/lang/Object class could not be created"))); | ||
| } | ||
| // Stack Trace |
There was a problem hiding this comment.
Please create a new function, for example jq_print_stack_trace(), to cover L1351 - L1381
| { | ||
| jobject sw = NewStringWriter(Jenv); | ||
| if (sw == NULL) { | ||
| ereport(ERROR, (errmsg("String Writer is null"))); |
There was a problem hiding this comment.
Because our purpose is to print stack trace at debug level (DEBUG3), so I think this error should only be displayed if DEBUG3 level is set in postgresql.conf.
| jobject pw = NewPrintWriter(Jenv, sw); | ||
| if (pw == NULL) { | ||
| (*Jenv)->DeleteLocalRef(Jenv, sw); | ||
| ereport(ERROR, (errmsg("Trace is null"))); |
There was a problem hiding this comment.
The message should be 'Print Writer is null'
|
|
||
| jstring trace = StringWriterToString(Jenv, sw); | ||
| (*Jenv)->DeleteLocalRef(Jenv, pw); | ||
| pw = NULL; |
There was a problem hiding this comment.
I think we don't need to set 'sw' and 'pw' to NULL.
| ereport(ERROR, (errmsg("Trace is null!!!"))); | ||
| } | ||
|
|
||
| exceptionStackTraceString = jdbc_convert_string_to_cstring((jobject) trace); |
There was a problem hiding this comment.
please fix the ident in this line of code.
|
could you add test case(s) to verify the added code? |
3 participants
If the JDBC driver throws an exception, it is helpful to print the stacktrace while debugging.