CP-17382 skipattributes no longer skips mysql#17383
Merged
Merged
Conversation
Assited-by: Claude Code
Assisted-by: Claude Code
Assisted-by: Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
In raising this pull request, I confirm the following:
Fixed
Phalcon\Mvc\Modelignoring attributes registered withskipAttributes(),skipAttributesOnCreate()andskipAttributesOnUpdate(), so a skipped column was emitted in the generatedINSERT/UPDATE(breaking, for instance, inserts into a table with a MySQL generated column). The skip list is keyed withnullvalues, andisset()on an array offset now follows PHP semantics (key present and value notnull), which made every skipped attribute read as not registered; the checks indoLowInsert(),doLowUpdate()and the not-null validation now usearray_key_exists().Thanks