T14 di reset guard#16
Merged
Merged
Conversation
Assisted-by: Claude Code
This comment has been minimized.
This comment has been minimized.
Assisted-by: Claude Code
This comment has been minimized.
This comment has been minimized.
Code Metrics Report
Details | | master (fcf0421) | T14-di-reset-guard (db62768) | +/- |
|---------------------|------------------|------------------------------|------|
| Coverage | 100.0% | 100.0% | 0.0% |
| Files | 46 | 46 | 0 |
| Lines | 774 | 777 | +3 |
+ | Covered | 774 | 777 | +3 |
| Test Execution Time | 1s | 1s | 0s |Code coverage of files in pull request scope (100.0% → 100.0%)
Reported by octocov |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
In raising this pull request, I confirm the following:
AbstractUnitTestCase::setUp()now guards itsDi::reset()call behindphalconAvailable(), so packages that use the Talon abstract test cases without Phalcon (or without the DI component) no longer hit a fatalClass "Phalcon\Di\Di" not foundat setup time - becauseAbstractUnitTestCaseis the root of the hierarchy, every abstract (AbstractServicesTestCase/AbstractDatabaseTestCase/AbstractBrowserTestCase/AbstractFunctionalTestCase) inherits the fix and can be extended without a DI. When Phalcon is available the reset still runs unchanged.Thanks