Skip to content

T14 di reset guard#16

Merged
niden merged 4 commits into
masterfrom
T14-di-reset-guard
Jul 10, 2026
Merged

T14 di reset guard#16
niden merged 4 commits into
masterfrom
T14-di-reset-guard

Conversation

@niden

@niden niden commented Jul 10, 2026

Copy link
Copy Markdown
Member

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

AbstractUnitTestCase::setUp() now guards its Di::reset() call behind phalconAvailable(), so packages that use the Talon abstract test cases without Phalcon (or without the DI component) no longer hit a fatal Class "Phalcon\Di\Di" not found at setup time - because AbstractUnitTestCase is the root of the hierarchy, every abstract (AbstractServicesTestCase/AbstractDatabaseTestCase/AbstractBrowserTestCase/AbstractFunctionalTestCase) inherits the fix and can be extended without a DI. When Phalcon is available the reset still runs unchanged.

Thanks

@niden niden self-assigned this Jul 10, 2026
@niden niden added the bug Something isn't working label Jul 10, 2026
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

Copy link
Copy Markdown

Code Metrics Report

master (fcf0421) T14-di-reset-guard (db62768) +/-
Coverage 100.0% 100.0% 0.0%
Test Execution Time 1s 1s 0s
Details
  |                     | master (fcf0421) | T14-di-reset-guard (db62768) | +/-  |
  |---------------------|------------------|------------------------------|------|
  | Coverage            |           100.0% |                       100.0% | 0.0% |
  |   Files             |               46 |                           46 |    0 |
  |   Lines             |              774 |                          777 |   +3 |
+ |   Covered           |              774 |                          777 |   +3 |
  | Test Execution Time |               1s |                           1s |   0s |

Code coverage of files in pull request scope (100.0% → 100.0%)

Files Coverage +/- Status
src/PHPUnit/AbstractBrowserTestCase.php 100.0% 0.0% modified
src/PHPUnit/AbstractUnitTestCase.php 100.0% 0.0% modified

Reported by octocov

@niden
niden merged commit 7e5da75 into master Jul 10, 2026
22 checks passed
@niden
niden deleted the T14-di-reset-guard branch July 10, 2026 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant