Skip to content

fix(security): keep symlink escape checks for unknown walk entries #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
phantom5099 merged 1 commit into from
Apr 23, 2026
Merged

fix(security): keep symlink escape checks for unknown walk entries #62

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion internal/security/workspace_paths.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,11 +57,31 @@ func ResolveWorkspaceWalkPathFromRoot(root string, target string, entry fs.DirEn
if !isWithinWorkspace(root, absoluteTarget) {
return "", fmt.Errorf("security: path %q escapes workspace root", target)
}
if entry != nil && entry.Type().IsRegular() {
if isVerifiedRegularWalkEntry(entry) {
return absoluteTarget, nil
}
if _, err := ensureNoSymlinkEscape(root, absoluteTarget, target); err != nil {
return "", err
}
return absoluteTarget, nil
}

// isVerifiedRegularWalkEntry 判断 WalkDir 条目是否可安全走普通文件快速路径。
// 对 Type()==0 的条目会再调用 Info 二次确认，避免“未知类型”误判为普通文件而绕过符号链接校验。
func isVerifiedRegularWalkEntry(entry fs.DirEntry) bool {
if entry == nil {
return false
}
entryType := entry.Type()
if !entryType.IsRegular() {
return false
}
if entryType != 0 {
return true
}
info, err := entry.Info()
if err != nil {
return false
}
return info.Mode().IsRegular()
}
Loading