[Method Browser] Baseline update and fixes#1405
Merged
jecisc merged 7 commits intopharo-spec:Pharo14from Apr 24, 2026
Merged
Conversation
Added the refactoring command packages by default in the baseline. As well, updated initialization so the code editor can be marked dirty. Lastly, precised the title when there is no results
Member
|
The navigation system tests are not related? |
Contributor
Author
No it is linked to recent changes on click events I believe |
jecisc
reviewed
Apr 24, 2026
Comment on lines
42
to
55
| { | ||
| StRenameClassCommand. | ||
| StExtractTempCommand. | ||
| StConvertTempToInstVarCommand. | ||
| StInlineMethodCommand. | ||
| StRenameArgOrTempCommand. | ||
| StGenerateVariableAccessorCommand. | ||
| StMoveInstanceVariableToClassSideCommand. | ||
| StPushUpVariableCommand. | ||
| StPushDownVariableCommand. | ||
| StRemoveVariableCommand. | ||
| StProtectVariableCommand } do: [ :cmdClass | group register: (cmdClass forSpecContext: methodBrowser) ]. | ||
| StProtectVariableCommand. | ||
| StRenameVariableCommand } do: [ :cmdClass | group register: (cmdClass forSpecContext: methodBrowser) ]. | ||
| ^ group |
Member
There was a problem hiding this comment.
This can be change in a future PR but I don't like hardcoded list like this. Ideally we should collect the commands. Because if I want to customize my IDE with my own command, I cannot we a hard coded list :(
Contributor
Author
There was a problem hiding this comment.
i understand, I was thinking of changing it too
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename Variable+ test!Implementors of #printOn: No Results).