Introduce refactoring commands for Spec#1892
Merged
Ducasse merged 12 commits intopharo-spec:Pharo14from Apr 23, 2026
Merged
Conversation
This is the start of the migration of refactoring commands, used now for the method browser. We could use these for other places that deal with the code presenter (Playground,...) but we will need an unified API.
Contributor
Author
|
Failing test for selector not implemented is normal since this is introduced in this PR |
Contributor
|
I think the PR has a code loading problem: pharo-project/pharo#19590 |
Contributor
Author
|
@MarcusDenker I will try to fix this, btw could you look to merge pharo-spec/NewTools#1403 please, because New Tools CI is failing too |
Contributor
merged! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the start of the migration of refactoring commands, used now for the method browser.
For now I implemented :
-
Rename Class-
Extract Temp-
Convert temp to inst varWe could use these for other places that deal with the code presenter (Playground,...) but we will need an unified API.
I also added test for the commands to check if the navigation through AST is well plugged to drivers.
Created a mock context for the tests, also need a special PR for the driver in pharo repo