fix(client): fall back to defaults when preset storage is corrupt#5184
Open
jeffrey701 wants to merge 1 commit into
Open
fix(client): fall back to defaults when preset storage is corrupt#5184jeffrey701 wants to merge 1 commit into
jeffrey701 wants to merge 1 commit into
Conversation
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
loadPresets was the lone localStorage loader that JSON.parse'd without a try/catch (loadActiveGame, loadWsSession, loadActiveQuickDraft, … all guard and return a fallback). A malformed 'phase-game-presets' value threw a SyntaxError, and because savePreset/deletePreset both call loadPresets first, all three crashed and took down the game-setup preset UI. Wrap the parse and fall back to DEFAULT_PRESETS.
8a040ab to
d059c30
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
loadPresets(client/src/services/presets.ts) is the only localStorage loader in the module that callsJSON.parsewithout a try/catch:Every sibling loader (
loadActiveGame,loadWsSession,loadActiveQuickDraft, …) wraps the parse and returns a fallback. So a corrupt/partialphase-game-presetsvalue (e.g. a write interrupted mid-flush, or an older schema) throws aSyntaxError. And becausesavePresetanddeletePresetboth callloadPresets()first, all three throw — the game-setup preset UI crashes rather than recovering.Fix
Wrap the parse in try/catch and fall back to
DEFAULT_PRESETS, matching the other loaders.Tests
Adds
presets.test.ts: corrupt storage ("{oops") makesloadPresets/savePreset/deletePresetthrow before the fix and return/no-throw after; empty storage yields the defaults; valid storage round-trips a saved preset.Self-contained: only
presets.ts+ a new test; no engine/Rust/protocol changes.Model: claude-opus-4-8