-
Notifications
You must be signed in to change notification settings - Fork 7
docs: update README with branding images #1148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -1,8 +1,22 @@ | ||||||||||||
| # amp-devcontainer | ||||||||||||
|
|
||||||||||||
| <!-- markdownlint-disable --> | ||||||||||||
|
||||||||||||
| <a href="https://github.com/philips-software/amp-devcontainer"> | ||||||||||||
| <div align="center"> | ||||||||||||
| <picture> | ||||||||||||
| <source media="(prefers-color-scheme: dark)" srcset="https://github.com/user-attachments/assets/bd514b53-60de-4206-b97d-be4971d4908f"> | ||||||||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. is this supposed to be visible in the readme view? on inspect I can see the code but I don't see the expect image
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. While checking it out from my GitHub app I also don't see the image. I wonder if it is scoped to my user account, I was trying to refrain from adding the images to the repository. But I don't know if that will hold. |
||||||||||||
| <img alt="amp-devcontainer" src="https://github.com/user-attachments/assets/9ac111f8-7349-42e1-9778-d05d65969ba6"> | ||||||||||||
| </picture> | ||||||||||||
|
Comment on lines
4
to
7
|
||||||||||||
| <picture> | |
| <source media="(prefers-color-scheme: dark)" srcset="https://github.com/user-attachments/assets/9ac111f8-7349-42e1-9778-d05d65969ba6"> | |
| <img alt="Flutter" src="https://github.com/user-attachments/assets/9ac111f8-7349-42e1-9778-d05d65969ba6"> | |
| </picture> | |
| <img alt="amp-devcontainer logo" src=".github/assets/amp-devcontainer-logo.svg"> |
Copilot
AI
Feb 9, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using <i> for emphasis is more “presentational” than semantic. Prefer <em> (or plain Markdown emphasis) for better accessibility/semantics, and consider dropping the leading -- if it’s only decorative (screen readers will read it literally).
Copilot
AI
Feb 9, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The markdownlint re-enable directive looks incorrect. markdownlint expects <!-- markdownlint-enable --> (with a space), not <!-- markdownlint-enable -->. With the current comment, markdownlint may stay disabled for the rest of the file.
Copilot
AI
Feb 9, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The README disables all markdownlint rules for the entire header block. It’s usually better to disable only the specific rule(s) needed (commonly MD033 for inline HTML) to avoid hiding other formatting issues in that section. Consider changing this to a targeted disable (e.g., <!-- markdownlint-disable MD033 -->) and re-enabling afterward.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The markdownlint re-enable directive looks incorrect. markdownlint expects
<!-- markdownlint-enable -->(with a space), not<!-- markdownlint-enable -->. With the current comment, markdownlint may stay disabled for the rest of the file.