[pull] devel from ansible:devel#572
Open
pull[bot] wants to merge 1982 commits intophilipsd6:develfrom
Open
Conversation
github-actions
bot
added
component:api
component:ui
community
component:awx_collection
labels
github-actions
bot
added
the
dependencies
Co-authored-by: Peter Braun <pbranu@redhat.com>
…15956) (#6958) * Make the JT name uniqueness enforced at the database level * Forgot demo project fixture * New approach, done by adding a new field * Update for linters and failures * Fix logical error in migration test * Revert some test changes based on review comment * Do not rename first template, add test * Avoid name-too-long rename errors * Insert migration into place * Move existing files with git * Bump migrations of existing * Update migration test * Awkward bump * Fix migration file link * update test reference again
* [2.5/4.6 Backport] AAP-40782 Reduce queued stuck jobs * [2.5/4.6 Backport] AAP-40782 Reduce queued stuck jobs * Incrp'd review feedback from @AlanCoding * Reformatted 4 files per CI-check for api-linters
``` /var/lib/awx/venv/awx/lib64/python3.11/site-packages/_pytest/python.py:163: PytestReturnNotNoneWarning: Expected None, but awx/main/tests/unit/test_tasks.py::TestJobCredentials::test_custom_environment_injectors_with_boolean_extra_vars returned ['successful', 0], which will be an error in a future version of pytest. Did you mean to use `assert` instead of `return`? ``` * Dug into the git blame for this one 0605854 is the commit for any historians. It was wrongfully carried over from a mock pexpect implementation. Our new tests are nice. They don't go as far as trying to run the task so they do not need to mock pexpect. That is why it is safe to remove this code without finding it a new home. Co-authored-by: Chris Meyers <chris.meyers.fsu@gmail.com>
* Adds a workflow that rebases release_4.6 onto release_4.6-next
* 🧪 Unpersist Git creds @ cov combine job This is one of the things Zizmor [[1]] warns about. [1]: https://docs.zizmor.sh * 🧪 Download all coverage artifacts in one go * 🧪 Delegate artifact garbage collection to GH This is implemented by setting the retention days input to 1 on the initial upload.
* 🧪 Unpersist Git creds @ cov combine job This is one of the things Zizmor [[1]] warns about. [1]: https://docs.zizmor.sh * 🧪 Download all coverage artifacts in one go * 🧪 Delegate artifact garbage collection to GH This is implemented by setting the retention days input to 1 on the initial upload. Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <webknjaz@redhat.com>
* Add back PYTEST_ARGS * use pytest adopts
* update collection arguments * Add integration testing for new param * fix: sanity check failures --------- Co-authored-by: Sean Sullivan <ssulliva@redhat.com> Co-authored-by: Alan Rominger <arominge@redhat.com>
* Update the workflow to allow the action to write our branches from it. * Also added username and email as git by default will want to know who is performing the action (edge case). Using github actions bot is standard practice
* Update database to credential types in new migration file * bump migration * Add assertion * Pre-delete credentials so we test recreation
* base64 encode user inputed url when logging so that newlines or other malicious payloads can't be injected into the log stream
Changed two instances of 'cancelled' to 'canceled' in awx/main/wsrelay.py to match AWX's standardized American English spelling convention. - Updated log message in WebsocketRelayConnection.connect() - Updated comment in WebSocketRelayManager.cleanup_offline_host() Fixes #15177 Signed-off-by: Joey Washburn <joey@joeywashburn.com>
The OpenAPI schema incorrectly showed all 12 credential type kinds as valid for POST/PUT/PATCH operations, when only 'cloud' and 'net' are allowed for custom credential types. This caused API clients and LLM agents to receive HTTP 400 errors when attempting to create credential types with invalid kind values. Add postprocessing hook to filter CredentialTypeRequest and PatchedCredentialTypeRequest schemas to only show 'cloud', 'net', and null as valid enum values, matching the existing validation logic. No API behavior changes - this is purely a documentation fix. Co-authored-by: Claude <noreply@anthropic.com>
* Enable new fancy asyncio metrics for dispatcherd Remove old dispatcher metrics and patch in new data from local whatever Update test fixture to new dispatcherd version * Update dispatcherd again * Handle node filter in URL, and catch more errors * Add test for metric filter * Split module for dispatcherd metrics
* Update OpenAPI spec * lint fixes * fix decorator for retrieve endpoints * change decorator method * fix import * lint fix
Bump pyasn1 for CVE-2026-2349 Signed-off-by: Seth Foster <fosterbseth@gmail.com>
…troller Jobs (#16259) * AAP-62657 Add populate_claims_for_workload function and unit tests * Update safe_get helper function * Trigger CI rebuild to pick up latest django-ansible-base * Trigger CI after org visibility update * Retrigger CI * Rename workload to job, refine safe_get helper function * Update test_jobs to use job fixture * Retrigger CI * Create fresh job, removed launched_by since this is read-only property * Retrigger CI after runner issues * Retrigger CI after runner issues * Add unit tests for other workload types * Update CLAIM_LAUNCHED_BY_USER_NAME and CLAIM_LAUNCHED_BY_USER_ID, with CLAIM_LAUNCHED_BY_NAME and CLAIM_LAUNCHED_BY_ID * Generate claims with a more static schema try to operate directly on object when possible For cases where field is valid for the type, but null value still add the field, so blank and null values appear * Allow unified related items to be omittied --------- Co-authored-by: AlanCoding <arominge@redhat.com>
Fix server error from PATCH to inventory source, co-authored with Claude opus 4.6
fix: align pip version constraint in requirements_dev.txt with requirements.txt (fixes #16272) requirements.txt pins pip==25.3 while requirements_dev.txt specified pip>=21.3,<=24.0, causing ResolutionImpossible when installing both. Updated requirements_dev.txt to use pip>=25.3 to maintain compatibility.
* Multiple credentialtype's have the same kind and kind values look like: cloud, network, machine, etc. * namespace is the field that we want to rename
* Introduced in PR https://github.com/ansible/awx/pull/16058/changes then a later large merge from AAP back into devel removed the changes * This PR re-introduces the github app lookup migration rename tests with the migration names updated and the kind to namespace correction
Signed-off-by: Seth Foster <fosterbseth@gmail.com>
…16276) The awx CLI derives available fields for the `modify` command from the list endpoint's POST action schema. Users with object-level admin permissions (e.g., Project Admin) but no list-level POST permission see no field flags, making modify unusable despite having PUT access on the detail endpoint. Fall back to the detail endpoint's action schema when POST is not available on the list endpoint, and prefer PUT over POST when building modify arguments. Signed-off-by: Seth Foster <fosterbseth@gmail.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The schema-swagger-ui URL was removed from awx/api/urls/urls.py in d7eb714 when docs endpoints moved to DAB's api_documentation app, but the reverse call in ApiRootView was not removed, causing a NoReverseMatch error in development mode. Signed-off-by: Seth Foster <fosterbseth@gmail.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…6281) * Added token authentication in logic, arguments, and test
* When the remote host header values contains a comma separated list, only consider the first entry. Previously we considered every item in the list.
#16289) * do not add optional survey fields with empty strings that are not backed by extra_vars * exclude password fields from skipping if not defined
This reverts commit 08f1507.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )