Feat: add recursive group search#37
Conversation
|
This explains why I couldn't find some things, I'd love to see this added! |
ericonr
left a comment
ericonr
left a comment
There was a problem hiding this comment.
What I didn't understand was how the version of gitlab-search installed via npm worked for finding a project belonging to a subgroup since I only specified the group
| 2. Create a [personal GitLab access token](https://docs.gitlab.com/ee/user/profile/personal_access_tokens.html#creating-a-personal-access-token) with the `read_api` scope. | ||
|
|
||
| ## Installation | ||
|
|
| "-g, --groups <group-names>", | ||
| "group(s) to find repositories in (separated with comma)", | ||
| ) | ||
| |> option("-r, --recursive", "Search recursively in projects in the given groups") |
There was a problem hiding this comment.
Nit: lowercase is used for the other options (also update README)
| ## Installing from source | ||
| 1. Install node 14.x | ||
| 2. Clone this repository | ||
| 3. Build with | ||
| ```sh | ||
| $ npm run build | ||
| ``` | ||
| 4. Run from bin directory | ||
| ```sh | ||
| $ bin/gitlab-search.js -h | ||
| ``` |
There was a problem hiding this comment.
Shouldn't this be a separate commit?
The prerequisites don't list a specific NodeJS version, and it doesn't seem to be required from what I tested.
|
Some news? @phillipj |
|
Hi @marsluca, Any improvements going forward, will have to be made on the TypeScript rewrite: #45. If you could help out giving that beta version a try, I'd be grateful as it would set the stage for merging & publishing a new version, before consider porting these changes into TypeScript. In case you're not interested in trying it out, I'd suggest forking the project and adding these changes into your version of it. |
5 participants
fix #34