Skip to content

[RTLD] Add interpreter support#511

Draft
badochov wants to merge 3 commits intomasterfrom
badochov/interp
Draft

[RTLD] Add interpreter support#511
badochov wants to merge 3 commits intomasterfrom
badochov/interp

Conversation

@badochov
Copy link
Copy Markdown
Contributor

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: (list targets here).

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

  • This PR needs additional PRs to work (list the PRs, preferably in merge-order).
  • I will merge this PR by myself when appropriate.

@badochov badochov requested a review from agkaminski January 30, 2024 15:24
@badochov badochov force-pushed the badochov/interp branch 3 times, most recently from e5feb8b to 0bdb77c Compare January 30, 2024 15:36
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 30, 2024

Unit Test Results

6 410 tests  ±0   5 780 ✅ ±0   33m 19s ⏱️ -3s
  354 suites ±0     630 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit 48ec15d. ± Comparison against base commit 9cc5f71.

♻️ This comment has been updated with latest results.

@agkaminski
Copy link
Copy Markdown
Member

Pls rebase, as one of the commits of this PR has been already merged

@badochov badochov force-pushed the badochov/interp branch 7 times, most recently from 2e92e05 to 48ec15d Compare February 2, 2024 13:51
@badochov badochov marked this pull request as draft February 2, 2024 14:29
@badochov badochov force-pushed the badochov/interp branch 3 times, most recently from 84e90dd to 8387026 Compare August 6, 2024 16:34
@badochov badochov force-pushed the badochov/interp branch 7 times, most recently from 5342ae8 to 091f9ff Compare August 22, 2024 21:23
@badochov badochov force-pushed the badochov/interp branch 3 times, most recently from b1900d3 to eb4bff5 Compare September 12, 2024 13:20
@badochov badochov force-pushed the badochov/interp branch 2 times, most recently from 8c28e80 to 245decd Compare October 6, 2024 13:05
@badochov badochov changed the title [RTLD] Add 32bit interpreter support [RTLD] Add interpreter support Oct 16, 2024
@badochov badochov force-pushed the badochov/interp branch 2 times, most recently from b2a92a2 to a2fbd36 Compare October 24, 2024 14:12
proc/process.c Outdated
vm_objectPut(interpO);
return err;
}
err = vm_objectPut(interpO);;
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[clang-format-pr] reported by reviewdog 🐶
suggested fix

Suggested change
err = vm_objectPut(interpO);;
err = vm_objectPut(interpO);
;

proc/process.c Outdated
vm_objectPut(interpO);
return err;
}
err = vm_objectPut(interpO);;
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[clang-format-pr] reported by reviewdog 🐶
suggested fix

Suggested change
err = vm_objectPut(interpO);;
err = vm_objectPut(interpO);
;

@badochov badochov force-pushed the badochov/interp branch 2 times, most recently from 6b5828e to 63cefa6 Compare October 25, 2024 15:10
@badochov badochov force-pushed the badochov/interp branch 3 times, most recently from 39adf4d to 1246887 Compare March 27, 2025 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants