Skip to content

Optimize URI scheme detection for paths #4330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SteffenDE merged 1 commit into from
Jul 15, 2026
+5 −5
Merged

Optimize URI scheme detection for paths #4330

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions lib/phoenix_live_view/utils.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -617,14 +617,14 @@ defmodule Phoenix.LiveView.Utils do
# Returns the lowercased URI scheme of `to` if it begins with one, that is, a
# ":" appears before any "/", "?" or "#"; otherwise returns nil. This avoids
# treating a colon in a path segment, query, or fragment as a scheme.
defp uri_scheme("/" <> _to), do: nil

defp uri_scheme(to) do
case :binary.match(to, [":", "/", "?", "#"]) do
{pos, 1} ->
if binary_part(to, pos, 1) == ":",
do: String.downcase(binary_part(to, 0, pos), :ascii),
else: nil
{pos, 1} when binary_part(to, pos, 1) == ":" ->
String.downcase(binary_part(to, 0, pos), :ascii)

:nomatch ->
_ ->
nil
end
end
Expand Down
Loading