Improve error recovery in collections#21
Merged
Conversation
Add context-aware error recovery that prevents cascading errors when
parsing malformed arrays and inline tables.
Changes:
- Add bracket stack tracking to monitor nesting context
- Implement synchronizeInCollection() that recovers to next comma or
closing bracket instead of skipping to newline
- Add parseInlineTableKeyValue() and parseKeyWithoutSync() to avoid
line-based synchronization inside inline tables
- Update parseArray() and parseInlineTable() to use bracket-aware recovery
Before: `{a = 1, b = , c = 3}` would generate 3-5 cascading errors
After: Same input generates 1 precise error at the correct location
This enables better IDE/tooling support by providing more accurate
error locations and preserving more of the document structure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements improved error recovery
synchronizeInCollection()that recovers to next comma or closing bracket instead of skipping to newlineparseArray()andparseInlineTable()to use bracket-aware recoveryBefore vs After
Before: 4 cascading errors
After: 1 precise error
This enables better IDE/tooling support by providing more accurate error locations and preserving more of the document structure.