Fix #93 silent Warning: unexpected NAN value was coerced to string#95
Closed
remicollet wants to merge 1 commit intophp-decimal:masterfrom
Closed
Fix #93 silent Warning: unexpected NAN value was coerced to string#95remicollet wants to merge 1 commit intophp-decimal:masterfrom
remicollet wants to merge 1 commit intophp-decimal:masterfrom
Conversation
Contributor
|
using this patch for Alpinelinux PHP 8.5 and 2.0.1 release but 3 tests still fail, probably arch related |
Contributor
|
Taking a look. |
Contributor
|
Fixed in v2.0.2, I think 8.5 alpine tests are passing now? There's a Dockerfile in the root now, which runs in CI too. |
Contributor
|
Thanks @remicollet! Cherry-picked your fix in e88fdfb and tagged v2.0.2. Also added Alpine Docker support and GitHub Actions CI (PHP 8.2-8.5 on Debian and Alpine). |
Contributor
|
@rtheunissen for Alpine failures I asked Claude to research and now tests pass, probably it affects 8.4/8.5 both #96 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using PHP 8.5.5