Skip to content

Fix #93 silent Warning: unexpected NAN value was coerced to string#95

Closed
remicollet wants to merge 1 commit intophp-decimal:masterfrom
remicollet:issue-93
Closed

Fix #93 silent Warning: unexpected NAN value was coerced to string#95
remicollet wants to merge 1 commit intophp-decimal:masterfrom
remicollet:issue-93

Conversation

@remicollet
Copy link
Copy Markdown
Contributor

Using PHP 8.5.5

=====================================================================
TEST RESULT SUMMARY
---------------------------------------------------------------------
Exts skipped    :     0
Exts tested     :    20
---------------------------------------------------------------------

Number of tests :   131               131
Tests skipped   :     0 (  0.0%) --------
Tests warned    :     0 (  0.0%) (  0.0%)
Tests failed    :     0 (  0.0%) (  0.0%)
Tests passed    :   131 (100.0%) (100.0%)
---------------------------------------------------------------------
Time taken      : 0.265 seconds
=====================================================================

@andypost
Copy link
Copy Markdown
Contributor

using this patch for Alpinelinux PHP 8.5 and 2.0.1 release but 3 tests still fail, probably arch related

TEST 48/131 [tests/Decimal/operators.phpt]
========DIFF========
--
         [value] => 100000000
         [precision] => 12
     )
011- Operator not supported by decimal numbers
========DONE========

TEST 85/131 [tests/Number/operators.phpt]
========DIFF========
--
     (
         [value:protected] => 1E+8
     )
010- Operator not supported by decimal numbers
========DONE========

TEST 127/131 [tests/Rational/operators.phpt]
========DIFF========
--
         [num] => 100000000
         [den] => 1
     )
011- Operator not supported by decimal numbers
011+ 
012+ Termsig=0
========DONE========

@rudi-augment
Copy link
Copy Markdown
Contributor

Taking a look.

@rtheunissen
Copy link
Copy Markdown
Contributor

Fixed in v2.0.2, I think 8.5 alpine tests are passing now? There's a Dockerfile in the root now, which runs in CI too.

@rtheunissen
Copy link
Copy Markdown
Contributor

Thanks @remicollet! Cherry-picked your fix in e88fdfb and tagged v2.0.2. Also added Alpine Docker support and GitHub Actions CI (PHP 8.2-8.5 on Debian and Alpine).

@andypost
Copy link
Copy Markdown
Contributor

@rtheunissen for Alpine failures I asked Claude to research and now tests pass, probably it affects 8.4/8.5 both #96

@remicollet remicollet deleted the issue-93 branch April 15, 2026 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants