Skip to content

Rename abstract class to prevent PHPUnit warning on 8.2#27

Open
andypost wants to merge 1 commit intophp-ds:masterfrom
andypost:php82-fix
Open

Rename abstract class to prevent PHPUnit warning on 8.2#27
andypost wants to merge 1 commit intophp-ds:masterfrom
andypost:php82-fix

Conversation

@andypost
Copy link
Copy Markdown

Faced it upgrading to 1.5.3 on Alpinelinux PHP 8.2.30, related to #24

ds

ds support => enabled
ds version => 2.0.0
PHPUnit 11.5.55 by Sebastian Bergmann and contributors.

Runtime:       PHP 8.2.30
Configuration: /mnt/testing/php82-pecl-ds/src/ds-2.0.0/tests/phpunit.xml

.............................................................   61 / 1891 (  3%)
.............................................................  122 / 1891 (  6%)
.............................................................  183 / 1891 (  9%)
.............................................................  244 / 1891 ( 12%)
.............................................................  305 / 1891 ( 16%)
.............................................................  366 / 1891 ( 19%)
.............................................................  427 / 1891 ( 22%)
.............................................................  488 / 1891 ( 25%)
.............................................................  549 / 1891 ( 29%)
.............................................................  610 / 1891 ( 32%)
.............................................................  671 / 1891 ( 35%)
.............................................................  732 / 1891 ( 38%)
.............................................................  793 / 1891 ( 41%)
.............................................................  854 / 1891 ( 45%)
.............................................................  915 / 1891 ( 48%)
.............................................................  976 / 1891 ( 51%)
............................................................. 1037 / 1891 ( 54%)
............................................................. 1098 / 1891 ( 58%)
............................................................. 1159 / 1891 ( 61%)
............................................................. 1220 / 1891 ( 64%)
............................................................. 1281 / 1891 ( 67%)
............................................................. 1342 / 1891 ( 70%)
............................................................. 1403 / 1891 ( 74%)
............................................................. 1464 / 1891 ( 77%)
............................................................. 1525 / 1891 ( 80%)
............................................................. 1586 / 1891 ( 83%)
............................................................. 1647 / 1891 ( 87%)
............................................................. 1708 / 1891 ( 90%)
............................................................. 1769 / 1891 ( 93%)
............................................................. 1830 / 1891 ( 96%)
............................................................. 1891 / 1891 (100%)


Time: 00:00.761, Memory: 16.00 MB

There was 1 PHPUnit test runner warning:

1) Class Ds\Tests\CollectionTest declared in /mnt/testing/php82-pecl-ds/src/ds-2.0.0/tests/vendor/php-ds/tests/tests/CollectionTest.php is abstract

OK, but there were issues!
Tests: 1891, Assertions: 5679, PHPUnit Warnings: 1.
>>> ERROR: php82-pecl-ds: check failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant