[composer] Scope ProxyCommand under composer adapter#270
Merged
Conversation
Signed-off-by: Felipe Sayão Lobato Abreu <github@mentordosnerds.com>
Signed-off-by: Felipe Sayão Lobato Abreu <github@mentordosnerds.com>
Contributor
|
🚀 Preview is available for this pull request. |
Signed-off-by: Felipe Sayão Lobato Abreu <github@mentordosnerds.com>
Co-authored-by: Copilot <copilot@github.com> Signed-off-by: Felipe Sayão Lobato Abreu <github@mentordosnerds.com>
Signed-off-by: Felipe Sayão Lobato Abreu <github@mentordosnerds.com>
Co-authored-by: Copilot <copilot@github.com> Signed-off-by: Felipe Sayão Lobato Abreu <github@mentordosnerds.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Continue hardening issue #199 by standardizing standards-pipeline command naming and improving command discovery safety, while retaining practical backwards compatibility.
Changes
standards:phpdoctostandards:dockblockand keepdockblock+php-cs-fixeraliases for compatibility.StandardsCommandto run the PHPDoc step throughphp-cs-fixer, forwarding--cacheand--cache-dirtophp-cs-fixerandreportsonly; route cache directory to.dev-tools/cache/php-cs-fixer.dockblock,php-cs-fixer) while intentionally dropping only the legacystandards:phpdoccommand name.DevToolsCommandLoaderto guard duplicate command/alias registration and throw a deterministicRuntimeExceptionon collision.FixtureDuplicateCommandNameandDevToolsCommandLoaderTest.CHANGELOG.md(Unreleased) describing these command naming and compatibility changes.Testing
./vendor/bin/phpunit tests/Console/Command/StandardsCommandTest.php./vendor/bin/phpunit tests/Console/CommandLoader/DevToolsCommandLoaderTest.phpCloses #199
Closes #200
Closes #201
Closes #202
Closes #203
Closes #204
Closes #205
Closes #206
Closes #207
Closes #208
Closes #209
Closes #210
Closes #211
Closes #212
Closes #213
Closes #214
Closes #215
Closes #216
Closes #217
Closes #218
Closes #219
Closes #220
Closes #221
Closes #222
Closes #223
Closes #224
Closes #225