[command] Respect raw output when rendering DevTools banner#279
Closed
[command] Respect raw output when rendering DevTools banner#279
Conversation
Signed-off-by: Felipe Sayão Lobato Abreu <github@mentordosnerds.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implemented a central logo rendering decision in the DevTools console entrypoint and applied it so command output uses the ASCII banner only for non-raw flows.
Changes
shouldRenderLogo()logic inDevToolsto compute logo visibility from command name and options.changelog:next-versionandchangelog:show, which previously relied on raw output contracts and now do not print banner.--no-logo,--json, and--pretty-jsonbefore any output rendering.tests/Console/DevToolsTest.phpto validate that raw changelog commands skip the logo.Testing
vendor/bin/phpunit tests/Console/DevToolsTest.php.Review note
Logo gating is centralized in
DevTools::doRun()viashouldRenderLogo(InputInterface $input).Closes #277
Implementation note: raw/changelog-raw behavior is now controlled at the command-boot layer (
isRawOutputCommand) so each command avoids per-command output flags and remains orchestrator-safe.