Skip to content

Treat IDREF mismatches as warnings in non-English translations #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jordikroon wants to merge 1 commit into
base: master
Choose a base branch
from
+42 −6
Open

Treat IDREF mismatches as warnings in non-English translations #303

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 42 additions & 6 deletions configure.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -990,14 +990,50 @@ function xml_validate_jing()
echo "done.\n";
return;
}
else

// For non-English translations, IDREF mismatches are treated as warnings instead of errors,
// because outdated translations may reference IDs that have yet to be translated from doc-en.

$isEnglish = $GLOBALS['ac']['LANG'] === 'en';
$errors = [];
$warnings = [];

if ( is_array( $out ) )
{
echo "failed.\n";
if ( is_array( $out ) )
foreach ( $out as $line )
echo "$line\n";
errors_are_bad( 1 );
foreach ( $out as $line )
{
if ( !$isEnglish && preg_match( '/IDREF "[^"]+" without matching ID/', $line ) )
{
$warnings[] = $line;
}
else
{
$errors[] = $line;
}
}
}

if ( count( $warnings ) > 0 )
{
echo "\n" . count( $warnings ) . " IDREF warning(s) (translation out of sync with doc-en):\n";
foreach ( $warnings as $line )
{
echo "$line\n";
}
}

if ( count( $errors ) === 0 )
{
echo "done.\n";
return;
}

echo "failed.\n";
foreach ( $errors as $line )
{
echo "$line\n";
}
errors_are_bad( 1 );
}

function xml_validate_libxml( $dom )
Expand Down