Skip to content

Add brotli and zstd checks for Windows builds #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bix0r merged 1 commit into from
May 11, 2026
+8 −1
Merged

Add brotli and zstd checks for Windows builds #98

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/windows-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ jobs:
php-version: ${{ matrix.php-version }}
arch: ${{ matrix.arch }}
ts: ${{ matrix.ts }}
libs: 'zlib,libxml2,libcurl,libiconv,libssh2,openssl,nghttp2'
libs: 'zlib,libxml2,libcurl,libiconv,libssh2,openssl,nghttp2,brotli,libzstd'
release:
runs-on: ubuntu-latest
needs: build
Expand Down
7 changes: 7 additions & 0 deletions config.w32
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,13 @@ if(PHP_SOLR != 'no')
WARNING('solr was not enabled; nghttp2 library not found');
PHP_SOLR = "no";
}
if(!CHECK_LIB('brotlidec-static.lib;brotlidec.lib', 'solr', PHP_SOLR) ||
!CHECK_LIB('brotlicommon-static.lib;brotlicommon.lib', 'solr', PHP_SOLR)) {
WARNING('brotli libraries were not found; Accept-Encoding brotli may be unavailable');
}
if(!CHECK_LIB('libzstd_a.lib;libzstd.lib', 'solr', PHP_SOLR)) {
WARNING('zstd library not found; Accept-Encoding zstd may be unavailable');
}
if(!CHECK_LIB('crypt32.lib', 'solr', PHP_SOLR)) {
WARNING('solr was not enabled; crypt32 library not found');
PHP_SOLR = "no";
Expand Down
Loading