Use ZEND_LONG_EXCEEDS_INT over manual bound checking

edorian · edorian · commit e508ea640d86 · 2026-05-29T16:01:55.000+02:00
diff --git a/ext/bcmath/bcmath.c b/ext/bcmath/bcmath.c
@@ -157,7 +157,7 @@ static zend_always_inline zend_result bcmath_check_scale(zend_long scale, uint32
 
 static zend_result bcmath_check_precision(zend_long precision, uint32_t arg_num)
 {
-	if (UNEXPECTED(precision < INT_MIN || precision > INT_MAX)) {
+	if (ZEND_LONG_EXCEEDS_INT(precision)) {
 		zend_argument_value_error(arg_num, "must be between %d and %d", INT_MIN, INT_MAX);
 		return FAILURE;
 	}

Original file line number	Diff line number	Diff line change
`@@ -157,7 +157,7 @@ static zend_always_inline zend_result bcmath_check_scale(zend_long scale, uint32`
`157`	`157`
`158`	`158`	`static zend_result bcmath_check_precision(zend_long precision, uint32_t arg_num)`
`159`	`159`	`{`
`160`		`- if (UNEXPECTED(precision < INT_MIN \|\| precision > INT_MAX)) {`
	`160`	`+ if (ZEND_LONG_EXCEEDS_INT(precision)) {`
`161`	`161`	`zend_argument_value_error(arg_num, "must be between %d and %d", INT_MIN, INT_MAX);`
`162`	`162`	`return FAILURE;`
`163`	`163`	`}`