Stream errors#20524
Closed
bukka wants to merge 1 commit into
Closed
Conversation
bukka
force-pushed
the
stream_errors
branch
2 times, most recently
from
490d6e4 to
7bc37ff
Compare
bukka
force-pushed
the
stream_errors
branch
3 times, most recently
from
2858058 to
0e557c4
Compare
bukka
requested review from
DanielEScherzer,
dstogov and
kocsismate
as code owners
DanielEScherzer
approved these changes
Feb 28, 2026
DanielEScherzer
left a comment
DanielEScherzer
left a comment
Member
There was a problem hiding this comment.
Updating ext/reflection/tests/ReflectionExtension_getClassNames_basic.phpt for new classes looks good to me, okay for ext/reflection
bukka
force-pushed
the
stream_errors
branch
3 times, most recently
from
e729e8e to
176987f
Compare
bukka
added a commit
to bukka/php-src
that referenced
this pull request
May 28, 2026
This introduces new stream error handling that allows configurable handling of stream errors. This can be configured in stream contex. All streams, ext/standard and ext/phar stream errors are converted to use the new API. RFC: https://wiki.php.net/rfc/stream_errors Closes phpGH-20524
This introduces new stream error handling that allows configurable handling of stream errors. This can be configured in stream contex. All streams, ext/standard and ext/phar stream errors are converted to use the new API. RFC: https://wiki.php.net/rfc/stream_errors Closes phpGH-20524
bukka
pushed a commit
that referenced
this pull request
Jun 14, 2026
Since GH-20524, _php_stream_open_wrapper_ex() attaches the context to a stream that has none, including the implicitly substituted default context. Sharing the default context by reference let a later stream_context_set_option() on the stream mutate the global default context, leaking options into every other context-less stream. Only attach explicitly provided contexts. Stream errors already fall back to the default context when the stream has none, so error handling is unaffected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This introduces new stream error handling that allows configurable handling of stream errors. This can be configured in stream contex.
RFC: https://wiki.php.net/rfc/stream_errors