Skip to content

Benchmark job does not need gmp#21601

Closed
mvorisek wants to merge 2 commits into
php:masterfrom
mvorisek:bench_no_gmp
Closed

Benchmark job does not need gmp#21601
mvorisek wants to merge 2 commits into
php:masterfrom
mvorisek:bench_no_gmp

Conversation

@mvorisek

@mvorisek mvorisek commented Apr 2, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@mvorisek mvorisek requested a review from TimWolla as a code owner April 2, 2026 09:59
@iluuu1994

Copy link
Copy Markdown
Member

intdiv() uses zend_long, which is limited to 64 bits. I realize it's unlikely for this to overflow, but the old code is more technically correct, and hence I don't see a point in changing it. 32 bit is a different story, it can and would actually overflow there.

@mvorisek

mvorisek commented Apr 2, 2026

Copy link
Copy Markdown
Contributor Author

I understand, you want to keep 32-bit support even for this test script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants