zend_api: Use return true / return false for functions returning bool

[LamentXU123]

same as #21649

[iluuu1994]

You missed quite a few of them.

[TimWolla]

You missed quite a few of them.

This kind of change should be done in bulk with Coccinelle and if Coccinelle doesn't catch all of them, it should be investigated why. The main reason I only did zend_compile.c in the linked PR is because I planned some work on the compiler specifically.

[LamentXU123]

Yea I directly use Coccinelle for this. Now, Lets change the missed case and I plan to open one PR to change these cases in bulk in the future

@TimWolla Seems like The Coccinelle script in the linked PR couldn't match cases wit different indent. e.g.
It can match:

foo();
return 0;

It can't match

foo;
    return 0;

See if this would be better instead:

@r1@
identifier fn;
typedef bool;
@@

bool fn(...)
{
...
(
- return 0;
+ return false;
|
- return 1;
+ return true;
)
...
}

[LamentXU123]

Oh, also I'm curious about why we are doing these refactors (I submit this just because I saw someone else did XD) .If benefits are little I think maybe we could avoid this code churn🤔

[github-actions]

There has not been any recent activity in this PR. It will automatically be closed in 7 days if no further action is taken.