Add new zend APIs for bin2hex to remove ext/hash usage in various extensions#21724
Open
LamentXU123 wants to merge 5 commits into
Open
Add new zend APIs for bin2hex to remove ext/hash usage in various extensions#21724LamentXU123 wants to merge 5 commits into
bin2hex to remove ext/hash usage in various extensions#21724LamentXU123 wants to merge 5 commits into
Conversation
This reverts commit e24a9d6.
Member
|
I'm in favour of this as I think ideally extensions shouldn't have dependencies on other extensions if it can be avoided. |
Contributor
Author
I think It'd be okay to have dependencies but in this case the function used in ext/hash is bin2hex which is so simple that we really don't have to depend on it :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are various extensions in the php code base that includes ext/hash/php_hash for the
php_hash_bin2hexmethod. While these method is actually simple, we can make them as APIs in the zend engine to remove the dependence on ext/hash/