check cp bounds before reading A6 partial short in php_parserr#22201
Open
alhudz wants to merge 1 commit into
Open
check cp bounds before reading A6 partial short in php_parserr#22201alhudz wants to merge 1 commit into
alhudz wants to merge 1 commit into
Conversation
Girgias
approved these changes
Jun 14, 2026
Girgias
left a comment
Girgias
left a comment
Member
There was a problem hiding this comment.
LGTM, should this be backported to 8.4?
Author
|
Yeah, the same unguarded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed the A6 branch in php_parserr reads cp[0] for the partial short without the CHECKCP guard every other field read in this function uses. With a 1-byte A6 rdata whose masklen % 16 is 9..15, cp already sits at end, so that byte is read past the response data and lands in the ipv6 string. Guard it like the surrounding reads.