Skip to content

std/dba: validate file permission argument in dba_open() #22228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arshidkv12 wants to merge 2 commits into
base: master
Choose a base branch
from
+55 −1
Open

std/dba: validate file permission argument in dba_open() #22228

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eef932a
std/dba: validate file permission argument in dba_open()
arshidkv12 Jun 4, 2026
0831a46
std/dba: validate file permission argument in dba_open()
arshidkv12 Jun 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ext/dba/dba.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -563,7 +563,10 @@ static void php_dba_open(INTERNAL_FUNCTION_PARAMETERS, bool persistent)
zend_argument_must_not_be_empty_error(3);
RETURN_THROWS();
}
// TODO Check Value for permission
if (permission < 0 || (permission & ~07777) != 0) {
zend_argument_value_error(4, "Invalid file permission value (must be between 0 and 07777)");
RETURN_THROWS();
}
Comment on lines +566 to +569

@Girgias Girgias Jun 14, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be good to have some sort of global API for this, as many INI settings also should be checking valid permissions, and do all of those changes in one single PR rather than scattered around.

@arshidkv12 arshidkv12 Jun 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check it #22302

if (map_size < 0) {
zend_argument_value_error(5, "must be greater than or equal to 0");
RETURN_THROWS();
Expand Down
51 changes: 51 additions & 0 deletions ext/dba/tests/dba_permission.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,51 @@
--TEST--
DBA permission validation (invalid bits check)
--EXTENSIONS--
dba
--SKIPIF--
<?php
if (!in_array('flatfile', dba_handlers())) die('skip flatfile handler not available');
?>
--FILE--
<?php

$filename = __DIR__ . DIRECTORY_SEPARATOR . 'test.db';

function test($permission, $filename) {
try {
dba_open($filename, "c", "flatfile", $permission);
echo "OK\n";
} catch (ValueError $e) {
echo "VALUE_ERROR\n";
} catch (Throwable $e) {
echo "ERROR\n";
}

@unlink($filename);
}

/* valid permissions */
test(0777, $filename);
test(0755, $filename);
test(0644, $filename);
test(0000, $filename);

/* invalid permissions */
test(010000, $filename);
test(020000, $filename);
test(-1, $filename);

?>
--EXPECT--
OK
OK
OK
OK
VALUE_ERROR
VALUE_ERROR
VALUE_ERROR
--CLEAN--
<?php
$filename = __DIR__ . DIRECTORY_SEPARATOR . 'test.db';
@unlink($filename);
?>
Loading