Skip to content

Fix GH-22360: convert.base64-encode corruption on incremental flush. #22368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
devnexen wants to merge 2 commits into from
+25 −1
Closed

Fix GH-22360: convert.base64-encode corruption on incremental flush. #22368

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
418e318
Fix GH-22360: convert.base64-encode corruption on incremental flush.
devnexen Jun 20, 2026
3b589fa
add test
devnexen Jun 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ext/standard/filters.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1519,7 +1519,7 @@ static php_stream_filter_status_t strfilter_convert_filter(
php_stream_bucket_delref(bucket);
}

if (flags != PSFS_FLAG_NORMAL) {
if (flags & PSFS_FLAG_FLUSH_CLOSE) {
if (strfilter_convert_append_bucket(inst, stream, thisfilter,
buckets_out, NULL, 0, &consumed,
php_stream_is_persistent(stream)) != SUCCESS) {
Expand Down
24 changes: 24 additions & 0 deletions ext/standard/tests/filters/gh22360.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
--TEST--
GH-22360 (convert.base64-encode emits padding on incremental flush)
--FILE--
<?php
$file = __DIR__ . '/gh22360.tmp';
$fp = fopen($file, 'w');
stream_filter_append($fp, 'convert.base64-encode', STREAM_FILTER_WRITE);

fwrite($fp, "ab");
fflush($fp);
fwrite($fp, "c");
fflush($fp);
fclose($fp);

var_dump(file_get_contents($file));
echo base64_encode("abc"), PHP_EOL;
?>
--CLEAN--
<?php
@unlink(__DIR__ . '/gh22360.tmp');
?>
--EXPECT--
string(4) "YWJj"
YWJj
Loading