Zend: Make instanceof object equivalent to is_object()#22375
Open
dseguy wants to merge 1 commit into
Open
Conversation
`$x instanceof object` was syntactically valid but always returned false because `object` is a pseudo-type with no corresponding class entry in the class table. This made the construct silently unusable. At compile time, when the right-hand side of `instanceof` is the literal `object` pseudo-type, emit `ZEND_TYPE_CHECK` with `MAY_BE_OBJECT` instead of `ZEND_INSTANCEOF`. This is the same opcode used by `is_object()`, so `$x instanceof object` now behaves identically to `is_object($x)`. The fix is entirely at compile time; no VM handler changes are required.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
$x instanceof objectwas syntactically valid but always returned false becauseobjectis a pseudo-type with no corresponding class entry in the class table. This made the construct silently unusable.At compile time, when the right-hand side of
instanceofis the literalobjectpseudo-type, emitZEND_TYPE_CHECKwithMAY_BE_OBJECTinstead ofZEND_INSTANCEOF. This is the same opcode used byis_object(), so$x instanceof objectnow behaves identically tois_object($x).The fix is entirely at compile time; no VM handler changes are required.